fix(android build): fixing the "namespace missing" android build error related to issue #19

erikas-taroza / audiotags

Read and write audio metadata in Flutter. Supports multiple formats.

https://pub.dev/packages/audiotags

MIT License

11 stars 7 forks source link

fix(android build): fixing the "namespace missing" android build error related to issue #19 #20

Closed josereia closed 4 months ago

josereia commented 4 months ago

Added the namespace "com.erikas.audiotags" to build.gradle, removed the package property from AndroidManifest.xml and changed minSdkVersion to 21 to fix the "namespace missing" compile error and to meet Google's new requirements for Android in new versions of Gradle and AGP.

BREAKING CHANGE: Android sdk minimum version updated from 16 to 21 Closes #19

erikas-taroza commented 4 months ago

Hey. Thanks for the PR. Let me do some testing on this because I have a feeling that removing the package declaration in the manifest will break for anyone not using gradle 8.

josereia commented 4 months ago

Thank you very much for your review, I really hadn't realized the compatibility issue.

I've already sent a new commit in response to your request: add the package property back to AndroidManifest.xml and make the build.gradle namespace conditional.