search

erikas-taroza / audiotags

Read and write audio metadata in Flutter. Supports multiple formats.
https://pub.dev/packages/audiotags
MIT License
9 stars 4 forks source link

Not every image is getting parsed #4

Closed sanihaq closed 1 year ago

sanihaq commented 1 year ago

sample song

erikas-taroza commented 1 year ago

The issue is audiotags tries to get the picture with type CoverFront. The file has a picture type of Other which is why it didn't retrieve it.

I will work on improving the picture API. I plan on allowing multiple pictures with different formats and types.

sanihaq commented 1 year ago

@erikas-taroza Hi, I don't know where to ask this exactly, but…

  1. would you mind formatting your rust code according to official style guidelines (use rust-lang/rustfmt)
  2. if not, would you mind providing a .editorconfig(or similar for vscode) file.
  3. overall, make this and “simple_audio” more friendly to other contributors.

Anyway, thanks for this and other amazing package. Keep up the good work. 👍

erikas-taroza commented 1 year ago

1. would you mind formatting your rust code according to official style guidelines (use rust-lang/rustfmt)

Sure.

3. overall, make this and “simple_audio” more friendly to other contributors.

These are my first open source projects that I have published. I apologize if some things are missing. Could you give some suggestions?

sanihaq commented 1 year ago

@erikas-taroza you should create a CONTRIBUTING.md file explaining setting up the project or any other advice, rules to follow. There are other files you can include, like a CODE_OF_CONDUCT file. A LICENSE file is a must.

For this project, flutter_rust_bridge will be a new thing for most newcomers. So a bit of explanation about that will be helpful. For me, I'm not really sure how you set that up with your project.

erikas-taroza commented 1 year ago

I see. I will take this into account. It's getting late for me so I will do this tomorrow.

sanihaq commented 1 year ago

@erikas-taroza take your time. good night.

erikas-taroza commented 1 year ago

I have updated pub.dev with the latest version. You should be able to fetch all the pictures as well as write multiple. I will make the repo more contributor friendly.