search

erikas-taroza / audiotags

Read and write audio metadata in Flutter. Supports multiple formats.
https://pub.dev/packages/audiotags
MIT License
9 stars 4 forks source link

[Feature request] Add track number field to metadata #6

Closed dannyglover closed 7 months ago

dannyglover commented 7 months ago

Hey, thanks for this great flutter plugin.

Do you have any plans to add more fields to the exposed metadata? Support for the track number would be great. Thank you.

erikas-taroza commented 7 months ago

Hey, thanks for this great flutter plugin.

Do you have any plans to add more fields to the exposed metadata? Support for the track number would be great. Thank you.

Sure, I will implement support for this.

dannyglover commented 7 months ago

Hey, thanks for this great flutter plugin. Do you have any plans to add more fields to the exposed metadata? Support for the track number would be great. Thank you.

Sure, I will implement support for this.

Thanks Erikas. Unrelated question...

I have a largeish music collection (1000 songs) and I'm getting errors reading the tags for various files (errors drilling down into your plugin) along with invalid picture data (using MemoryImage).

As the cause of this could be due to numerous things (filenames, special characters etc, bad metadata), it could be hard to reproduce at your end.

Would giving you read access to the music on my dropbox account help in diagnosing these problems at your end? Thanks again.

erikas-taroza commented 7 months ago

The files will help with debugging. You can compile a list of problem files and send them as a zip as an attachment.

dannyglover commented 7 months ago

The files will help with debugging. You can compile a list of problem files and send them as a zip as an attachment.

Thanks. I created a separate issue for that, to keep this one on topic. https://github.com/erikas-taroza/audiotags/issues/7

erikas-taroza commented 7 months ago

Ok thank you.

I have added support for the track number and track total metadata fields in ccbda92 Let me know if need any other fields. I will be happy to add them.

dannyglover commented 7 months ago

Ok thank you.

I have added support for the track number and track total metadata fields in ccbda92 Let me know if need any other fields. I will be happy to add them.

You work fast! Thank you very much.

I do have a list of other fields that would be great to have. I'll open a new issue for those.

PS: do you have a build bot that builds a new version of the plugin and pushes it live to pub.dev?

Thanks again.

erikas-taroza commented 7 months ago

I do have a list of other fields that would be great to have. I'll open a new issue for those.

Ok sounds good.

PS: do you have a build bot that builds a new version of the plugin and pushes it live to pub.dev?

No. I have a CD that creates the libraries and uploads them as a GitHub release asset. I still upload to pub.dev manually.