search

erikberglund / SwiftPrivilegedHelper

Example application using a privileged helper tool with authentication in an unsandboxed application written in Swift
MIT License
180 stars 33 forks source link

Enclosing the team identifier with double quotations #21

Open tnake opened 4 years ago

tnake commented 4 years ago

Thank you for your work. I use this project in my product. I encounter an issue that I can not execute my product expectedly, so that I report that issue.

I can execute my product correctly in the mode of Debug, whereas I could not execute my product which is exported from Organizer(which do Archive of product). I've investigate Info.plist, Helper-Info.plist, and CodeSignUpdate.sh, then I've had a doubt thing that the string of 'certificate leaf[subject.OU] = MY TEAM IDENTIFIER' is not containing double quotations. I think that above string 'MY TEAM IDENTIFIER' should be enclosing with double quotations. So that, I propose that in line 67 of CodeSignUpdate.sh: printf "%s" "certificate leaf[subject.OU] = ${developmentTeamIdentifier}" replace with printf "%s" "certificate leaf[subject.OU] = \"${developmentTeamIdentifier}\"" (i.e. ${developmentTeamIdentifier} is enclosed with double quotations).

Note that, I use Xcode 11. So, I've applied a workaround(https://github.com/erikberglund/SwiftPrivilegedHelper/issues/19).

gregcotten commented 3 years ago

can confirm this change is needed to build in "Release"

tnake commented 3 years ago

I've reported this issue, in doing Archive. However, doing Archive is the use of 'Release-mode' settings. So you can see probably this issue in Release-mode build. Does this answer your question?

gregcotten commented 3 years ago

I don't have a question - I am agreeing with you!