erikbern / ann-benchmarks

Benchmarks of approximate nearest neighbor libraries in Python
http://ann-benchmarks.com
MIT License
4.88k stars 735 forks source link

adding chroma #402

Closed jessfraz closed 5 months ago

jessfraz commented 1 year ago

making this a WIP so I can test, since I don't really know what I am doing :)

jessfraz commented 1 year ago

This one is a bit weird since there aren't a lot of options for metrics

kno10 commented 6 months ago

Would be cool to have chroma included in the benchmark, as it is very easy to use for beginners.

maumueller commented 6 months ago

This is so old that it will require some adaptions to the new code structure. @jessfraz: Why did it have draft status?

Looking at the wrapper, this seems to use qdrant internally, which is already a part of the benchmark.

kno10 commented 6 months ago

The chroma codebase does not appear to mention qdrant, but contains an hnsw.rs file: https://github.com/chroma-core/chroma/blob/main/rust/worker/src/index/hnsw.rs

The import from qdrant_client import ChromaClient is likely a leftover of search&replace conversion of the qdrant wrapper - ChromaClient is not used anywhere below, but chromadb.Client().

jessfraz commented 5 months ago

sorry this is super stale

erikbern commented 5 months ago

would love to add this one though – I can give it a shot (or someone else with a bit more time ideally)