erikbra / grate

grate - the SQL scripts migration runner
MIT License
209 stars 40 forks source link

Remove breaking spaces #554

Closed XelgoSett closed 4 months ago

XelgoSett commented 4 months ago

Hello, this is a possible solution to issue #536 :)

It looks like this may be a more general problem than just one folder name, and it requires a separate folder identifier and a user-friendly folder name. Please let me know if you would like me to prepare such changes.

But at the same time, Run After Create Database is a specific folder, and perhaps it can be fixed without major changes to the project. At least for now.

erikbra commented 4 months ago

Thanks a lot for your contribution, @XelgoSett . I see that I'm comparing apples and oranges here. As I mention in the linked issues, the folder confiuguration has become a bit messy, unfortunately. The whole configuration, and mess with knows folders, known folder names, and known folder keys should be re-written. They are. the result of the folder structure being fixed with RoundhousE, which I have inherited the start of grate from, and the folder configuration being fully dynamic in grate. I think I'd like to rewrite it a bit differently, and include a unit test to ensure that we know that the change works.

When fixing bugs, I usually start with writing a test that fails, to demonstrate the issue in a simple and easily reproducible way, and then implement the change, and see the test turning green. Then, I'm fairly sure that I have fixed the issue. And, all the other tests ensure (hopefully) that we haven't broken anything else

erikbra commented 4 months ago

Superceded by #565