search

erikd / http-proxy

A Haskell library for writing HTTP and HTTPS proxies.
Other
55 stars 21 forks source link

Implement waiRequest/proxyRequest #4

Closed olorin closed 9 years ago

olorin commented 9 years ago

Plus quickcheck of the roundtrip property. Note the dropping of requestHost and requestPort and use of raw Path; it'd probably be nice to at some point expose the URI as separate components in Request which would then be eliminated in waiRequest; maybe along the lines of network-uri? For now just the simplest implementation.

erikd commented 9 years ago

Hspec can do property based testing (using quickcheck under the hood). For example, see https://github.com/erikd/haskell-big-integer-experiment/blob/master/Check/NewX.template.hs#L58

olorin commented 9 years ago

Thanks for the comments - didn't realise hspec did that. Will update in the morning.

olorin commented 9 years ago

@erikd updated. I'm pretty sure those test failures are transient as I didn't touch that part of the code, but I can't ask travis to rebuild as it's not my repo.

erikd commented 9 years ago

Applied. Thanks.