erikd / http-proxy

A Haskell library for writing HTTP and HTTPS proxies.
Other
55 stars 21 forks source link

Can't modify CONNECT requests #6

Closed jcpetruzza closed 8 years ago

jcpetruzza commented 8 years ago

The case analysis to handle the CONNECT request is currently being done before applying proxyRequestModifier to the request. This means that one cannot have the proxy prevent certain CONNECT requests from succeeding nor fiddle with the host/port where to connect.

Is there a reason behind this?

erikd commented 8 years ago

No particular reason. I agree, what you suggest should be possible.

I'll probably get to it in the next couple of days.

erikd commented 8 years ago

That was easy. Version 0.1.0.1 on Hackage.

jcpetruzza commented 8 years ago

The fix and the upload to hackage are much appreciated, thanks!