erikdarlingdata / DarlingData

Open source SQL Server nonsense: sp_PressureDetector, sp_QuickieStore, sp_HumanEvents, etc.
https://www.erikdarling.com/
MIT License
475 stars 135 forks source link

Azure Hyperscale sys.query_store_runtime_stats | page_server_io fields #211

Closed mattnis closed 1 year ago

mattnis commented 1 year ago

Thank you for this project, I find it very useful. The results are just missing a few fields from sys.query_store_runtime_stats that relate to hyperscale databases.

https://learn.microsoft.com/en-us/sql/relational-databases/system-catalog-views/sys-query-store-runtime-stats-transact-sql?view=sql-server-ver16

Please see the fields with description containing: Applies to: Azure SQL Database Hyperscale

avg_page_server_io_reads .. .. stdev_page_server_io_reads

erikdarlingdata commented 1 year ago

@mattnis I'm not interested in supporting that at all. If you'd like to add the code, you're welcome to do so and submit a pull request.

mattnis commented 1 year ago

Not interested in supporting the project or just not supporting Hyperscale? These page_server_io fields are also relevant for performance tuning.

-Matt-

On Wed, Feb 15, 2023 at 11:02 AM Erik Darling @.***> wrote:

@mattnis https://github.com/mattnis I'm not interested in supporting that at all. If you'd like to add the code, you're welcome to do so and submit a pull request.

— Reply to this email directly, view it on GitHub https://github.com/erikdarlingdata/DarlingData/issues/211#issuecomment-1431690775, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7DP546WA5S5TZ6QEI5FLWXUDZBANCNFSM6AAAAAAU5DE3XE . You are receiving this because you were mentioned.Message ID: @.***>

erikdarlingdata commented 1 year ago

@mattnis not interested in supporting hyperscale. I don’t use it or have access to it for testing, and I don’t have any clients who use it. If it’s important to you, feel free to submit a pull request.

erikdarlingdata commented 1 year ago

@mattnis I haven't heard back from you on completing this in a couple months now, so I'm going to close it out.