search

erikdarlingdata / DarlingData

Open source SQL Server nonsense: sp_PressureDetector, sp_QuickieStore, sp_HumanEvents, etc.
https://www.erikdarling.com/
MIT License
443 stars 132 forks source link

sp_QuickieStore - Ignore disagreeable state when it's a readable secondary #414

Closed erikdarlingdata closed 1 month ago

erikdarlingdata commented 2 months ago

Is your feature request related to a problem? Please describe. I recently added some code to QuickieStore to check if Query Store is in a weird/different state from what's requested by the user. I didn't have any readable secondaries to test the code with, but it looks like we can ignore the check in that scenario.

Describe the solution you'd like Adjust the where clause to ignore it

Describe alternatives you've considered Telling people with Query Store on readable secondaries that their Query Store is being weird.

Are you ready to build the code for the feature? I sure do hope so.

IMPORTANT: If you're going to contribute code, please read the contributing guide first. https://github.com/erikdarlingdata/DarlingData/blob/main/CONTRIBUTING.md

erikdarlingdata commented 1 month ago

Apparently I did this at some point.