erikdarlingdata / DarlingData

Open source SQL Server nonsense: sp_PressureDetector, sp_QuickieStore, sp_HumanEvents, etc.
https://www.erikdarling.com/
MIT License
474 stars 133 forks source link

@get_all_databases = 1 vs @get_all_databases = 0 result in different periods of 8 days #422

Closed ehaar closed 4 months ago

ehaar commented 4 months ago

Version of the script

@version = '4.5',
@version_date = '20240401'

What is the current behavior? When executing the next statement

EXEC sp_QuickieStore @get_all_databases = 1
GO

then column 'period' in the second resultset shows a period from 8 days ago until today, which should be 7 days as a default. That's the first issue. Second issue: When executing the next statement

EXEC sp_QuickieStore @get_all_databases = 0
GO

then column 'period' in the second resultset shows a period from 7 days ago until tomorow, so 2 different periods that should be the same, and both spanning 8 days, which should be 7 days.

If the current behavior is a bug, please provide the steps to reproduce.

EXEC sp_QuickieStore @get_all_databases = 1
GO
EXEC sp_QuickieStore @get_all_databases = 0
GO

What is the expected behavior? Column 'period' in the second resultset shows a period from 7 days ago up and until today (7 days).

erikdarlingdata commented 4 months ago

@ehaar yeah, I'm aware of this, it just hasn't seemed that important to anyone (myself included). Are you planning on working on this?

erikdarlingdata commented 4 months ago

@ehaar I haven't heard back from you on this, but if you decide you want to work on it, leave a comment and I'll re-open it.

ehaar commented 4 months ago

Hi Erik, I'm enjoying a vacation, that's the reason. I will certainly try to work on it in the coming weeks.

Met vriendelijke groet,

Evert ter Haar

Senior Database Developer for SQL Server

Op wo 22 mei 2024 om 15:44 schreef Erik Darling @.***>:

@ehaar https://github.com/ehaar I haven't heard back from you on this, but if you decide you want to work on it, leave a comment and I'll re-open it.

— Reply to this email directly, view it on GitHub https://github.com/erikdarlingdata/DarlingData/issues/422#issuecomment-2124837209, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASERZM4PYJNWQG2C6WV2CY3ZDSOKRAVCNFSM6AAAAABHZ3Z56CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUHAZTOMRQHE . You are receiving this because you were mentioned.Message ID: @.***>

-- _ Deze e-mail en de inhoud daarvan is vertrouwelijk. Indien dit bericht niet voor u bestemd is, verzoeken wij u vriendelijk deze e-mail direct naar ons te retourneren en daarna te verwijderen. Openbaarmaking, vermenigvuldiging, verstrekking aan en/of gebruik door derden van dit e-mailbericht en/of informatie is niet toegestaan. Wij sluiten elke aansprakelijkheid uit in verband met het niet juist, onvolledig of niet tijdig overkomen van de informatie in deze e-mail.

This e-mail and its content are confidential and may be legally privileged. If this e-mail is not intended for you, please contact us immediately by reply e-mail and delete the e-mail. Please don't use, copy or disclose the e-mail and its contents to anyone. We are liable neither for the proper and complete transmission of the information in this e-mail nor for any delay in its receipt._