erikdarlingdata / DarlingData

Open source SQL Server nonsense: sp_PressureDetector, sp_QuickieStore, sp_HumanEvents, etc.
https://www.erikdarling.com/
MIT License
443 stars 132 forks source link

sp_QuickieStore.sql: Moved capturing of _date_original variables outside of loop. #432

Closed ReeceGoding closed 1 month ago

ReeceGoding commented 1 month ago

Closes #429 . As with the last @get_all_databases bug, I just had to move some bits outside of the loop and make something inside of the loop point to the now-outside bits. I think I'm finding one @get_all_databases-bug per month, which is a bit worrying.

As always, I must warn that I have never taken a deep look at how this procedure works, so I may have totally messed it up. It's clear that the date/UTC handling in this procedure is battle-worn, so it really is quite likely that I'm oblivious to something important. I have tried my best to make small changes that are true to the design and formatting, but this time it was worryingly easy. I was shocked to see that the @[...]_date_original variables already existed. It's as if somebody already tried to patch this bug.