erikdkennedy / figtree

A friendly, simple geometric sans serif font
SIL Open Font License 1.1
537 stars 20 forks source link

Cyrillic #15

Open drawcard opened 1 year ago

drawcard commented 1 year ago

Ok, I think I'm ready to push this to PR now! :)

There may be a second round of minor tweaks & adjustments to come, but it's probably ready for rollout so the wider community can test and give feedback.

I haven't generated the TTFs here, but if this needs to be done I can amend the PR.

Please have a look at the .glyphs file and let me know what you think!

StefanPeev commented 1 year ago

@drawcard Please send me your Cyrillic version. I would like to have a look at it. My e-mail: localfonts.eu@gmail.com. Best regards: Stefan Peev

drawcard commented 1 year ago

Hi @StefanPeev thanks for your interest - the latest updates for Cyrillic are published to my branch: https://github.com/drawcard/figtree/tree/cyrillic which you can download a ZIP / clone the repo of to check out the source files.

drawcard commented 1 year ago

@erikdkennedy could you please refresh my memory, is there anything further I need to do for the commit? eg. generate OTFs etc?

erikdkennedy commented 1 year ago

@drawcard You're good! My biggest issue is that if I'm going to incorporate Cyrillic, I would like to get it reviewed by at least one native-reading type designer – which looms like a large enough project in my mind that I've procrastinated on the whole thing. If you know of anyone though, let me know :)

emmamarichal commented 1 year ago

Hello everyone! I'm Emma and I'm working in the GF team as font onboarder. I can show the cyrillic to my colleagues, no problem for that.

My only concern is that I don't see any Cyrillic in the Italic version. To onboard this update, we will need the exact same glyphset in Roman and Italic.

Is it something you planned to do @drawcard? So I think we can close this PR, and if you draw the italic one day, you will open a new one :)

Don't hesitate if you have any questions, Cheers! Emma

drawcard commented 1 year ago

@erikdkennedy did you want to do the italic conversion, or are you OK with me taking it on? If so please send DM / email me your specs for converting to italic & can give it a shot. I'll wait for @emmamarichal's review before proceeding.

Also @emmamarichal we may produce a Greek character set as requested in #13, do you have anyone on your side who can help with reviewing that, when it's ready?

emmamarichal commented 1 year ago

cc @erikdkennedy @drawcard I think you can go ahead since you already done the roman version :)

I can eventually ask if somebody can tell me if it's good or not in term of design, to see if we onboard it or not, but we can't really provide a precise review. Our work concerns the technical and QA part. For the design, it would be better if you find someone who is a Greek reader an specialised on this field 👍

erikdkennedy commented 1 year ago

@drawcard just emailed you, but posting here for posterity: