search

erikdkennedy / figtree

A friendly, simple geometric sans serif font
SIL Open Font License 1.1
537 stars 20 forks source link

Nested components resulting in issues on Windows #31

Open kosmynkab opened 12 months ago

kosmynkab commented 12 months ago

The following glyphs glyphs have nested components: Dcroat gcommaaccent ij nine.tf onehalf onequarter threequarters oneeighth threeeighths fiveeighths seveneighths zeroinferior oneinferior twoinferior threeinferior fourinferior fiveinferior sixinferior seveninferior eightinferior nineinferior periodcentered.loclCAT space periodcentered.loclCAT.case quotedblbase quotedblright guillemetright lessequal

kenmcd commented 12 months ago

What applications have you had issues with?

kosmynkab commented 12 months ago

Microsoft Office on Windows machines for instance the quotedblbase displays as a single quote and prints as a single quote. Had the issue in the past in my own fonts – the source is the double nested components, which Google advises to get rid of in the files. I opened the source files in Glyphs and double checked that this is the issue.

kenmcd commented 12 months ago

Thanks. I was just curious which apps were affected. Hmmmm... There is a Font Bakery check which is supposed to check this. And the v2.001 fonts were merged/updated last week. But I see nothing in the FB report here: https://github.com/google/fonts/pull/6465 Perhaps @emmamarichal can shed some light on this.

emmamarichal commented 12 months ago

Hi @kosmynkab! Thanks for this report. Did you test with the current version on the API (2.000)? An update will be onboarded soon (2.001), and this is the result I got on Windows (Word). I don't have any problems linked to the nested components. But indeed, there are still a few left in the files (the ones you mentioned). If there are too many problems, we'll do an update by decomposing them.

Capture d’écran 2023-07-06 à 10 26 02
kenmcd commented 12 months ago

Microsoft Office on Windows machines

What version of Office? Windows 10?

kosmynkab commented 12 months ago

Microsoft Office Standard 2016 Windows 10 Pro 22H2 (Relaying information from the client)

image The first bottom quote should be quotedblbase

I had exactly the same characters and exactly the same issue with them with the custom typefaces that I prepared for them.

The files I used were the ones that they are using which come from the fonts.google website, however I tried with files exported from the Glyphs source files from Github on my end and the issue was the same. Just want to make sure that they are using exactly the same version of the font as the one available on GF and also that Figtree is ultimately bug free. Great typeface by the way, should have opened with that! ;)

emmamarichal commented 12 months ago

@kosmynkab Ok thanks! I removed nested components on my fork, and exported the variable. Could you test with this version? https://github.com/emmamarichal/figtree/tree/master/fonts/variable