erikdkennedy / figtree

A friendly, simple geometric sans serif font
SIL Open Font License 1.1
537 stars 20 forks source link

Add Figtree #5

Closed emmamarichal closed 1 year ago

emmamarichal commented 2 years ago

Hello @erikdkennedy!

I'm Emma, I am working with @RosaWagner to onboard fonts into the Google Fonts library. Your font is now ready to be published!

There were not a lot modifications, your file was super clean and met most of our specifications, thanks for that! Here are the few changes according to Google's specifications:

For everything to work properly, we need to name the stylistics sets. For the moment, I have named yours ss01 and ss02. If you want another name like "different a" for example, don't hesitate to let me know, I'll modify it before you merge this PR.

Don't hesitate if you have any question, Cheers!

Here is the QA if you want to have a look: QA.zip

erikdkennedy commented 2 years ago

Hi @emmamarichal ! :)

This is looking great – thanks for your hard work here.

Regarding weights, I only intended for there to be one weight between Regular and Bold (Medium). And in the QA images, it looks like Medium and SemiBold are very close together. Is it a GF requirement to have a 500 and 600 named weight, or can I get away with the static font having just Medium?

Regarding stylistic sets, ignore "g" and "t" (you can even delete those) – let's just do one called "Single-storey a" (though would it make more sense as a character variant rather than stylistic set?)

Thanks!

emmamarichal commented 1 year ago

Hi @erikdkennedy!

Yes we have to set these instances: https://googlefonts.github.io/gf-guide/variable.html#instantiated-static-fonts I agree that some styles are very close, what we can do, would be to choose other values for each instance, to better balance the styles.

I tried setting the medium to 500 instead of 540, and already I find that the difference is more visible. What do you think about it?

Capture d’écran 2022-07-14 à 11 06 59

I push these commits, if it's ok, you can merge, and if not I can try other values for the instances! Thank you :)