erikdkennedy / figtree

A friendly, simple geometric sans serif font
SIL Open Font License 1.1
537 stars 20 forks source link

Add Cyrillic support #6

Open Twilightssuperb opened 1 year ago

Twilightssuperb commented 1 year ago

Is it possible to create and implement cyrillic languages support?

erikdkennedy commented 1 year ago

I'm open to it. There are many improvements I need to make to the Latin set first (first and foremost, italics), so it won't be soon. But I'll leave this open for now, and others interested can upvote/comment.

drawcard commented 1 year ago

I'm interested in helping out with this. I've made a start at https://github.com/drawcard/figtree/tree/cyrillic

drawcard commented 1 year ago

I've completed the uppercase and lowercase character set for Cyrillic (Basic set), you can check out my branch to take a closer look.

I'm not a native Cyrillic writer, so it should be looked over by someone who is more familiar with Cyrillic. However I did study quite a few Cyrillic fonts while working on it, so hopefully it hits the mark.

Things to do before PR:

Future ideas:

CleanShot 2022-10-04 at 23 19 41@2x CleanShot 2022-10-04 at 23 14 30@2x
erikdkennedy commented 1 year ago

Looks like a fantastic start! Let me try and get some native readers to look it over. Thanks @drawcard ! 🙂

erikdkennedy commented 1 year ago

@drawcard I'd like to include Ukrainian with the initial PR.

Ґ ґ Є є І і Ї ї ₴

What else do we need for that?

drawcard commented 1 year ago

Thanks Erik!

For Ukrainian, I can complete the character set in Glyphs and update the branch. Shouldn't be too much effort to do.

I also posted in TypeDrawers to get some feedback, the comments have been helpful and I'll be working in those suggestions.

Will submit my PR soon!

Twilightssuperb commented 1 year ago

@drawcard, I add some line up to your mockup. It better shows that some letters don't have the same alignment (to bottom or top) and should be a bit smaller. Seems they are Э, Ю and small «е», «ё», «э», «ю». But I'm not sure of my viewpoint. Just glanced some details that could be matter.

Your mockup is fine.

My orange line is 2 px.

Figtree Cyrillic lineage mockup

drawcard commented 1 year ago

Thanks for this @Twilightssuperb - I'm not entirely sure if I understand the issue, as the rounded letter shapes have overshoots on them, for optical correction, so their extremes wouldn't line up with the other x-heights:

CleanShot 2022-10-05 at 23 29 11@2x CleanShot 2022-10-05 at 23 29 44@2x

Does that make sense, or does the issue lie somewhere else?

Twilightssuperb commented 1 year ago

Yep, I suggested it. It's not a bug or mistake, it's a typographic feature. Your drafts looks fine, don't bother. 🙂

I'm not a pro or designer to be nerdy or too strict, I'm just a kind of geek.

drawcard commented 1 year ago

Oh, I see now - thanks for pointing this out anyway!

lazarljubenovic commented 1 year ago

Serbian always gets left out 😭 ЉЊШЂЖЧЋ 🤟🏻

Here's my feedback for the current state:

comerc commented 3 months ago

@drawcard I can't install Cyrillic font on Mac. Please help me.

comerc commented 3 months ago

photo_2024-03-23_11-31-54

keycaps with this font :)

thejupitergroup commented 3 weeks ago

@drawcard I tried to download the fonts from your branch but they don't have the Cyrillic characters. Am I looking in the wrong place?