Closed nikolaykasyanov closed 8 years ago
I'm really sorry for bothering you (I've read the contribution guidelines), but is there any chance to get this merged?
Haven’t had a chance to look into it yet. I spent the time I had for OCMock on preparing #302.
@erikdoe thanks for the update! #302 looks great.
Merged this now. (I did change the test so that it fails when the new logic does't work.) Regarding your other test mentioned in the comment: this is a common misunderstanding; reject has nothing to do with verify. Interestingly, the changes proposed in #302 are hopefully going to make things clearer.
@erikdoe thank you!
Without that fix, a test using both async verification & rejections would wait for the whole given delay.
Performance test to confirm the problem & verify the fix included.
I also included baselines for the mentioned performance test.
I tried to write a regression test to verify that rejections do indeed work (i.e. throw) during async verification, like that:
But it seems that exceptions thrown inside the
NSRunLoop
call will crash the app immediately.