search

erikdoe / ocmock

Mock objects for Objective-C
http://ocmock.org
Apache License 2.0
2.16k stars 606 forks source link

Xcode 9.3 suggested changes #353

Closed nrbrook closed 5 years ago

erikdoe commented 6 years ago

Did you see that making the suggested changes makes the build fail? According to the Travis CI log "clang: error: -fobjc-weak is not supported on the current deployment target".

nrbrook commented 6 years ago

Sorry no I didn't actually test the build, I assumed it wouldn't break anything.

erikdoe commented 6 years ago

Thanks to this I realised that the Travis build was still using Xcode 7... I've updated this now and will recheck your PR once that change is through.

erikdoe commented 6 years ago

I have updated master so that I build with Xcode 9.3 on Travis CI. Can you update your PR and try again? The Travis build (in case Github doesn't show you the info) is here: https://travis-ci.org/erikdoe/ocmock/pull_requests

nrbrook commented 6 years ago

Still fails...

SFrost007 commented 6 years ago

We use OCMock as a child project of our main (iOS) project. When I perform the suggested changes on our parent project, the only resultant diffs to OCMock are identical to the *.xcscheme changes in this PR, with no changes to project.pbxproj.

Looking at the diff, these changes seem reasonably harmless and allow a project with a setup similar to ours to build without warnings/prompts.

Would it be possible to reduce the scope of this PR by removing the project file changes? Or would you be happy if I open a "competing" PR which just performs the xcscheme changes, to test this on Travis CI?

erikdoe commented 6 years ago

Either way, really. If this PR is modified so that the changes do not break the build on the CI server I'll merge it. Alternatively, if another PR is opened that upates the Xcode version without breaking the CI server, I'll merge that.