search

erikdoe / ocmock

Mock objects for Objective-C
http://ocmock.org
Apache License 2.0
2.16k stars 606 forks source link

Handle using nil as argument for andReturn in ObjC++ code. #404

Closed dmaclach closed 4 years ago

dmaclach commented 4 years ago

Fix for #403.

This improves the special case handling of passing nil in return values to handle C++ cases that previously weren't working.

Adds tests for C++11 and C++98 variants. To test fully tests need to be executed in both 32bit and 64 bit modes.

dmaclach commented 4 years ago

Anyone have any comments on this one? I think it's a no-brainer.

dmaclach commented 4 years ago

Oops.. looks like Erik is looking at it as I type :) Apologies.

dmaclach commented 4 years ago

Erik, do you have any plans you could share with regards to timing for OCMock 3.7, 3.8 etc? My pile of patches on my end is becoming a little scary :)

erikdoe commented 4 years ago

So, the plan was/is to get out 3.7 very soon. I got sidetracked by the PR's regarding Swift Package Manager, but I have now concluded that they won't be in 3.7. So, there's only two open PR's which seem reasonably straight-forward. I was also debating with myself whether #398 should be in, but I haven't read all the comments over there in detail.

dmaclach commented 4 years ago

We don't want #398 in its current state IMHO. I would think about it after

414 was available and see if it is still wanted/needed.

On Mon, Jul 13, 2020 at 2:04 PM Erik Doernenburg notifications@github.com wrote:

So, the plan was/is to get out 3.7 very soon. I got sidetracked by the PR's regarding Swift Package Manager, but I have now concluded that they won't be in 3.7. So, there's only two open PR's which seem reasonably straight-forward. I was also debating with myself whether #398 https://github.com/erikdoe/ocmock/pull/398 should be in, but I haven't read all the comments over there in detail.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/erikdoe/ocmock/pull/404#issuecomment-657792789, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACOFSPTASD2U6W3JT2OSGLR3NZFHANCNFSM4MKFOT2A .