erikdoe / ocmock

Mock objects for Objective-C
http://ocmock.org
Apache License 2.0
2.16k stars 606 forks source link

Switch to inclusive language for methods excluded from forwarding. #507

Closed benstiglitz closed 3 years ago

benstiglitz commented 3 years ago

Hi 👋,

I wanted to propose this small change to bring more inclusive terminology to a small piece of OCMock that’s choosing a set of methods to filter. This change of terminology to use the term blocklist is based on the Writing inclusively guidance in the Apple Style Guide.

Thanks for your consideration (and for the clear contribution guidelines you’ve laid out for this project).

dmaclach commented 3 years ago

Thanks for jumping on this Ben! Might I suggest denyList instead of blockList just because "block" is an overloaded term in Objective-C?

benstiglitz commented 3 years ago

@dmaclach I could certainly do that! Reading it again in context I wonder if it’d be better to get to the actual point and name it something like methodsNotToForward or selectorsNotToForward or selectorsIneligibleForForwarding. What do you think about those?

dmaclach commented 3 years ago

methodsNotToForward would get my vote.

benstiglitz commented 3 years ago

Done; thanks @dmaclach for the prompt to reconsider the mechanical rename I originally proposed.