search

erikdoe / ocmock

Mock objects for Objective-C
http://ocmock.org
Apache License 2.0
2.16k stars 606 forks source link

Do not require xcpretty #519

Closed marciniwanicki closed 1 year ago

marciniwanicki commented 2 years ago

Currently the Makefile relies on xcpretty being already installed.

I'd like to build OCMock myself, and ideally, limit the number of external dependencies needed to do so. Would it be OK to make the xcpretty an optional tool? e.g. if it's installed, the output is parsed and prettified, if not, raw output is printed out. We could achieve it by introducing a small wrapper snipped/or script used in the Makefile.

Side-note: Sadly, xcpretty is no longer maintained. Tuist org maintains an alternative https://github.com/tuist/xcbeautify which could be introduced as a followup.

erikdoe commented 1 year ago

The makefile is meant for a CI build. I want to keep it as simple as absolutely possible. Making the prettifier optional would add more logic to the file; logic that can go wrong. For that reason I'm not going to do this.

Now, I am in the process of switching OCMock from TravisCI to GitHub Actions, which would have been a good occasion to switch to a more modern prettifier. Sadly, though, it looks like the team at GitHub are not planning to add support for it: https://github.com/actions/runner-images/issues/6657 and https://github.com/actions/runner-images/discussions/8186.