search

erikdoe / ocmock

Mock objects for Objective-C
http://ocmock.org
Apache License 2.0
2.16k stars 606 forks source link

Add visionos platform support to podspec #530

Closed gabrieldonadel closed 1 year ago

gabrieldonadel commented 1 year ago

With the release of CocoaPods v1.13.0, visionOS support was introduced.

erikdoe commented 1 year ago

Now I realise, of course, that this PR only adds visionOS to the podspec file. How would I add this to the Xcode project file? I'm on the latest Xcode but when I add a target I can't even choose visionOS (it's not under "other" either):

Screenshot 2023-10-03 at 23 40 27
gabrieldonadel commented 1 year ago

Now I realise, of course, that this PR only adds visionOS to the podspec file. How would I add this to the Xcode project file? I'm on the latest Xcode but when I add a target I can't even choose visionOS (it's not under "other" either):

Screenshot 2023-10-03 at 23 40 27

AFAIK visionOS SDK is only available in Xcode Beta

image
erikdoe commented 1 year ago

Okay, makes sense. So far the policy was that released versions of OCMock should not depend on beta features of Apple's tools. If I were to merge this PR, what would happen when someone who doesn't have the Xcode beta installed adds a dependency to that version of OCMock? Would they still be able to use the pod? Or would it fail because it contains a platform that their Xcode doesn't know about? (I don't know CocoaPods well.)

gabrieldonadel commented 1 year ago

Okay, makes sense. So far the policy was that released versions of OCMock should not depend on beta features of Apple's tools. If I were to merge this PR, what would happen when someone who doesn't have the Xcode beta installed adds a dependency to that version of OCMock? Would they still be able to use the pod? Or would it fail because it contains a platform that their Xcode doesn't know about? (I don't know CocoaPods well.)

It should work, just like when you don't have a the watchos SDK installed in your Xcode for example

erikdoe commented 1 year ago

In case you wonder why this isn't released yet: #531