search

erikdoe / ocmock

Mock objects for Objective-C
http://ocmock.org
Apache License 2.0
2.16k stars 606 forks source link

Add visionOS support back to podspec #540

Open Saadnajmi opened 5 months ago

Saadnajmi commented 5 months ago

Cocoapods fully supports visionOS (which seemed to be why #532 had to revert the support), so let's add this back.

erikdoe commented 5 months ago

Thank you for bringing this up. That said, OCMock supports multiple package managers, and to “add visionOS support” it’s not sufficient to add it to the podspec only. If you want to increase the chance of this PR getting merged quickly, please includes changes for the other package managers, too.

Saadnajmi commented 5 months ago

@erikdoe Looking into it, it seems SPM should have visionOS support already, as I don't see a platforms filter in the Package.swift (so I assume it targets all platforms)? I can't tell for Carthage.. I think I'll need to update the pbxproj to have visionOS as a destination perhaps?

erikdoe commented 4 months ago

In order for this to progress, it looks like we need to resolve an issue with CocoaPods. For #537 I made a release yesterday, but I can't seem to push this release due to an error with CocoaPods:

➜  ocmock git:(master) pod trunk push --allow-warnings

[!] Found podspec `OCMock.podspec`
Updating spec repo `trunk`
[!] CDN: trunk URL couldn't be downloaded: https://cdn.cocoapods.org/deprecated_podspecs.txt Response: URL using bad/illegal format or missing URL

If I were to merge this PR and make a release with visionOS support, I assume I'd be running into the same problem. Anyone know what to do?

erikdoe commented 3 months ago

In the meantime I have resolved the problem with CocoaPods. So I could publish a pod with visionOS support. However we still need to add visionOS support for the other build styles.

@Saadnajmi As far as I can tell, you'd have to add a visionOS specific target to the Xcode project. Similar to how this is done for watchOS and tvOS.

Saadnajmi commented 3 months ago

@erikdoe Sounds good! I'll try to take a look this week. @okwasniewski fyi