It seems that there are spaces in the file name. (filename_.svg)

erikflowers / weather-icons

215 Weather Themed Icons and CSS

https://github.com/erikflowers/weather-icons

6.94k stars 853 forks source link

It seems that there are spaces in the file name. (filename_.svg) #248

Closed forejerk closed 3 years ago

forejerk commented 3 years ago

Hi. weather-icons is a great project. but It seems that there are spaces in the file name.

I found this ? while incorporating weather-icons into emoji-mart-vue. Some icon files cannot be loaded because there is a space character inserted between the extension and the file name. The file path in values/weathericons.xml is fine.

fox91 commented 3 years ago

Hi @reefle, unfortunately the SVG on this project aren't perfect on a lot of aspect (not only on the name). I'm currently working on version 3.* with this and other issue fixed. If this issue cause you trouble feel free to submit a PR.

Travelbacon commented 3 years ago

I had today issues with the white spaces. And as you can see, I made a small PR.

fox91 commented 3 years ago

Hi @Travelbacon, I've merged your PR. Thanks