search

erikflowers / weather-icons

215 Weather Themed Icons and CSS
https://github.com/erikflowers/weather-icons
6.91k stars 850 forks source link

Moon icons are slightly inaccurate #28

Closed crsaracco closed 9 years ago

crsaracco commented 9 years ago

The "Gibbous" moon icons are inaccurate - the dark part should be concave, not convex.

See http://stardate.org/nightsky/moon for details. Compare 2014-09-03 through 2014-09-06 to wi-moon-waxing-gibbous

Also, why is quarter not a straight line?

EDIT: derp I can't even use the right words for concave and convex.

erikflowers commented 9 years ago

The whole moon icon set needs to be rethought better. Building them for white backgrounds makes them not make sense if you use it on a dark background, and the phasing just isn't good since when you inverse the dark/light, things are backwards.

It probably needs a dark-background set that is just solid shapes and no outlnes, and then a light-background set that is like the existing ones, but better. Might have to copy something like this:

moon-phases

crsaracco commented 9 years ago

There isn't any clear new moon and full moon in that set, but I like the design of it.

Either way, thanks for making weather-icons!

erikflowers commented 9 years ago

I wish I had a better way of knowing who uses them, there's no way to really track it. The actual github-page gets 150~ or so visitors a day.

DaAwesomeP commented 9 years ago

@erikflowers,

All in all, lots of people rely on this (including me!).

DaAwesomeP commented 9 years ago

@crsaracco, It would seem that they ran out of letters. That is probably why they didn't half a full moon.

erikflowers commented 9 years ago

I had never looked at the stars or forks, that's funny. The traffic isn't bad either, about 300 a day. I didn't know to look at this... not being a real programmer I've never had a repo that mattered to anyone.

Maybe I should pay more attention. This was just some random idea at first that has ballooned into the #1 google result for "weather icons." Wish I wasn't do busy all the time...

Also yeah I should fix these if people are using them that much.

crsaracco commented 9 years ago

@DaAwesomeP: Honestly they probably didn't need to use all 26. I would have had a full moon, a new moon, both quarters, and then fill in the rest evenly (leaves 5 additional in between each one I listed before - plenty)

I am not at all familiar with font design, but couldn't you just use more characters too? numbers, for example.

I don't think it's worth a new issue, but I request a wi-night-alt-cloudy, too. As of now there's only a full moon, which can get kinda confused with a "partly cloudy" icon. EDIT: made a new issue for this.

erikflowers commented 9 years ago

Make a new issue if you want a new icon so I can close it when I add it for my own sanity.

Putting fonts on the letters is a no-no. All the icons exist in the PUA, private unicode area, where the hex value of the character is outside of any protected character, like A-Z, numbers, etc.

DaAwesomeP commented 9 years ago

I was just referring to the image, as they assigned letters to each phase. I did not mean it like a font.

On Sep 25, 2014, at 10:45 PM, "Erik Flowers" notifications@github.com wrote:

Make a new issue if you want a new icon so I can close it when I add it for my own sanity.

Putting fonts on the letters is a no-no. All the icons exist in the PUA, private unicode area, where the hex value of the character is outside of any protected character, like A-Z, numbers, etc.

— Reply to this email directly or view it on GitHub.

rdenadai commented 9 years ago

Reviving the topic here just to say that im using your icon set... and its great! Im also using very much you moon images! I have a moon information which shows the icon related to moon phase.

Im using your icon set in my Android app that shows information about different things... You could check out => https://play.google.com/store/apps/details?id=br.com.rdenadai.sensorial

Also i wouldnt mind to make a donation to your project or pay you some coffee... to help you get more time on it! ;)

thanks for your great work!

erikflowers commented 9 years ago

These have been changed. The old icons have been nulled out so they will appear as a blank box if you refer to the old classes since I don't want people using them.

There are now 28 moon icons, starting at new (nothing), day 8 is first quarter, day 15 is full moon, day 22 is 3rd quarter, and day 28 is whatever is right before new.

The names might just be something like wi-moon-0 through wi-moon-28.

Or maybe it will go wi-moon-new wi-moon-waxing-crescent-(1-6) wi-moon-first-quarter wi-moon-waxing-gibbous-(1-6) wi-moon-full wi-moon-waning-gibbous-(1-6) wi-moon-third-quarter wi-moon-waning-gibbous-(1-6)

Though it's never going to be perfect, people don't have to use all 28, and since the lunar cycle is really 4 sets of 7.4 days.

erikflowers commented 9 years ago

This is up, see http://weathericons.io

rdenadai commented 9 years ago

This is awesome, already update my app with the latest icon set! Thanks for the awesome work!!

erikflowers commented 9 years ago

inverted moon icons have been added under an alt-class