search

erikflowers / weather-icons

215 Weather Themed Icons and CSS
https://github.com/erikflowers/weather-icons
6.93k stars 854 forks source link

Added support for Sass. #60

Closed LasseHaslev closed 9 years ago

LasseHaslev commented 9 years ago

Added support for Sass, changed variables for DRY coding and created mixins for simplifying code. If you should add more icons, all you have to do is add it to the variables file and you are all set to compile the code :)

erikflowers commented 9 years ago

That looks way better than I do it. I do all the meticulous Less file updating one by one, with no loops or automation. Maybe I can figure out how to do something similar with Less as well.

From: LasseHaslev notifications@github.com Reply: erikflowers/weather-icons reply@reply.github.com> Date: February 11, 2015 at 11:09:36 AM To: erikflowers/weather-icons weather-icons@noreply.github.com> Subject:  [weather-icons] Added support for Sass. (#60)

Added support for Sass, changed variables for DRY coding and created mixins for simplifying code. If you should add more icons, all you have to do is add it to the variables file and you are all set to compile the code :)

You can view, comment on, or merge this pull request online at:

  https://github.com/erikflowers/weather-icons/pull/60

Commit Summary

Added support for Sass, changed variables for DRY coding and created mixins for simplifying code. Fixed issue with sass unicoding: see reference https://github.com/sass/sass/issues/1395#issuecomment-57658736 Added comments for each function. Added charset utf-8 to all files. Cleaned up variables. File Changes

A sass/partials/_functions.scss (6) A sass/partials/_mixins.scss (65) A sass/partials/_variables.scss (218) A sass/weather-icons.scss (12) M weather-icons/icon-classes.less (2) Patch Links:

https://github.com/erikflowers/weather-icons/pull/60.patch https://github.com/erikflowers/weather-icons/pull/60.diff — Reply to this email directly or view it on GitHub.

LasseHaslev commented 9 years ago

Yes, i think this approach also could be possible in Less. :) I forgot to add the font-face and the class for the icon to the output css. But created a new commit and this class should be good to go :)

LasseHaslev commented 9 years ago

When are you merging these changes?

erikflowers commented 9 years ago

I don't know. I have to pull the files down and put them in my development repo which is private, and then get everything organized in this repo. I don't actually work with any of the files in this repo, they're just copied here for public consumption. Maybe I should change how I do that.

erikflowers commented 9 years ago

I'm adding SASS for 2.0 so downloaded your files manually since there some other SASS contributions and I need to plan how to build 2.0 a lot better and include the Less and Sass. Thanks for doing this, it will be a part of the 2.0.

erikflowers commented 9 years ago

Sass has been successfully added as a language in the 2.0-wip