search

erikjanwestendorp / Our.Umbraco.Domains

Umbraco package which gives a simple overview of used domains.
5 stars 1 forks source link

Add domain #5

Open erikjanwestendorp opened 4 years ago

erikjanwestendorp commented 4 years ago

It would be nice if a new domain could be added from the dashboard, similar to the way languages ​​are added. When adding a domain it should be possible to choose the language, for example with a dropdown, enter a domain name and assign it to a content node.

ronaldbarendse commented 4 years ago

Just note that domains might get a sort order in the future (https://github.com/umbraco/Umbraco-CMS/pull/8316) and wildcard domains (no domain name, only setting the node culture) can only be added once per node.

callumbwhyte commented 4 years ago

Hey @erikjanwestendorp!

I love this package (should be the way domains are handled in Core IMHO!) and this feature would be great.

I'm going to work on a PR for this during my stream today!

Cheers, Callum

ronaldbarendse commented 4 years ago

@callumbwhyte Just know that Umbraco has quite a bit of business logic (or domain logic 😁) in the ContentController, instead of the DomainService: https://github.com/umbraco/Umbraco-CMS/blob/e9627f2ee962a73cd8c007a42845c9129e3339ee/src/Umbraco.Web/Editors/ContentController.cs#L1721-L1871

erikjanwestendorp commented 4 years ago

@callumbwhyte Thank you! Great that you want to work on it! I look forward to your PR :-)! I will definitely watch the stream! I assigned the issue to you!

@ronaldbarendse Thanks for your help as well, really appreciate that!