search

erikjhordan-rey / People-MVVM

Sample created to practice MVVM and DataBinding in Android Applications.
https://erikjhordan-rey.github.io/blog/2015/12/15/ANDROID-databinding-android.html
667 stars 193 forks source link

some doubt about this method #3

Closed rehan91 closed 7 years ago

rehan91 commented 7 years ago

private void unSubscribeFromObservable() { if (subscription != null && !subscription.isUnsubscribed()) { subscription.unsubscribe(); } }

!subscription.isUnsubscribed()??,i think this method is incorrect,i think we should remove this exclamation mark and use this method:subscription.isSubscribed().

rehan91 commented 7 years ago

e.......i understood this method ....