erikkaashoek / Comskip

A free commercial detector
GNU General Public License v2.0
598 stars 80 forks source link

Fails to build, macOS 12.2 #147

Closed AndrewBreyen closed 2 years ago

AndrewBreyen commented 2 years ago

Hello, having the same issue as #138, but when changing line 147, it also does not work, and gives more errors.

Steps to reproduce:

  1. git clone git://github.com/erikkaashoek/Comskip
  2. cd Comskip
  3. ./autogen.sh
  4. ./configure
  5. make
macmini@macserver Comskip % make
gcc -DPACKAGE_NAME=\"Comskip\" -DPACKAGE_TARNAME=\"comskip\" -DPACKAGE_VERSION=\"0.82.011\" -DPACKAGE_STRING=\"Comskip\ 0.82.011\" -DPACKAGE_BUGREPORT=\"https://github.com/erikkaashoek/Comskip/issues\" -DPACKAGE_URL=\"\" -DPACKAGE=\"comskip\" -DVERSION=\"0.82.011\" -DHAVE_LIBM=1 -DHAVE_LIBPTHREAD=1 -I.  -Wall -I/usr/local/Cellar/argtable/2.13/include -I/usr/local/Cellar/ffmpeg/5.0/include -DPROCESS_CC -DDONATOR  -g -O2  -MT comskip-comskip.o -MD -MP -MF .deps/comskip-comskip.Tpo -c -o comskip-comskip.o `test -f 'comskip.c' || echo './'`comskip.c
comskip.c:8876:9: error: implicit declaration of function 'list_codecs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        list_codecs();
        ^
comskip.c:14354:44: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                        frame[i].isblack = C_a;
                                           ^
comskip.c:279:18: note: expanded from macro 'C_a'
#define         C_a                     (1<<5)
                                          ^
comskip.c:14356:44: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                        frame[i].isblack = C_u;         // Checked
                                           ^
comskip.c:280:18: note: expanded from macro 'C_u'
#define         C_u                     (1<<3)
                                          ^
comskip.c:14358:44: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                        frame[i].isblack = C_s;
                                           ^
comskip.c:278:18: note: expanded from macro 'C_s'
#define         C_s                     (1<<2)
                                          ^
comskip.c:14360:44: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                        frame[i].isblack = C_s;                 // Checked
                                           ^
comskip.c:278:18: note: expanded from macro 'C_s'
#define         C_s                     (1<<2)
                                          ^
comskip.c:14362:44: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                        frame[i].isblack = C_u;
                                           ^
comskip.c:280:18: note: expanded from macro 'C_u'
#define         C_u                     (1<<3)
                                          ^
comskip.c:14366:40: warning: converting the result of '<<' to a boolean always evaluates to true [-Wtautological-constant-compare]
                    frame[i].isblack = C_b;
                                       ^
comskip.c:281:18: note: expanded from macro 'C_b'
#define         C_b                     (1<<4)
                                          ^
6 warnings and 1 error generated.
make: *** [comskip-comskip.o] Error 1