search

erikkaashoek / Comskip

A free commercial detector
GNU General Public License v2.0
598 stars 80 forks source link

Setting lowres=0 or 10 causes frequent SegFaul's #158

Open TMCsw opened 1 year ago

TMCsw commented 1 year ago

As subject says... ...Setting lowres=0 or 10 causes frequent Segmentation faults Tried setting lowres= 1,5,8 & 9 all seams to work fine (.edl outputs are the same for all) (tested on 22.04.1-Ubuntu x64_64)

TMCsw commented 1 year ago

Th real issue is probably more likely: probably with the setting: two_pass_logo=1 crashes consistently if the ..logo.txt isn’t already there.

ugly95 commented 2 months ago

I can confirm the issue. I compiled the latest version of comskip on Linux Mint 22. Using the default settings (e.g., no ini file), I get a segmentation fault.

As identified by @TMCsw, it appears the segfault occurs when the logo.txt file is created.

Setting two_pass_logo=0 avoids the issue.

booyakafoo commented 2 months ago

Thanks guys. I also was getting a seg fault and couldn't figure out what was happening. Don't know if it's better to disable two pass, or adjust my script to run again on abnormal/error exit. First pass actually creates the logo.txt and then I run a second pass and everything seems to work.

ugly95 commented 2 months ago

@booyakafoo I was thinking of adjusting my script to just create an empty logo file first before running comskip. But I haven't tested it yet.

So far with running comskip with two_pass_logo=0 I can't say I've noticed any difference in commercial detection. I haven't done a lot of recordings since making the change, since the new TV season hasn't really started yet.

rboy1 commented 2 months ago

Could the fix be related to this patch https://github.com/erikkaashoek/Comskip/pull/168