search

eriklharper / postcss-nested-import

@import stylesheets inside nested CSS
MIT License
17 stars 7 forks source link

Fork postcss-import #2

Open leebenson opened 7 years ago

leebenson commented 7 years ago

On reflection, I think it'd make more sense to fork and PR and postcss-import vs building a home-brew version.

postcss-import has a lot of functionality out-the-box, including duplicate detection and proper handling of paths and external resources. The only thing it's missing is an option to disable top-level @import checking, and concatenate in place.

It would probably make more sense to add an option for disabling top-level enforcement of imports and submit a PR than building something separate.

What do you think @eriklharper?

leebenson commented 7 years ago

the feature has already been suggested by one of the maintainers there, btw (https://github.com/postcss/postcss-import/issues/214#issuecomment-258257113) -- just hasn't been done yet.

eriklharper commented 7 years ago

I totally agree, I think its silly to reinvent the wheel of what's already been built.

dehuszar commented 6 years ago

Is this refactor still planned? I have need of this plugin as a dependency to my own, due to postcss-import's spec-strictness.

Akimyou commented 4 years ago

See this issue. It seems postcss-import no want to support css scoped nested import.

https://github.com/postcss/postcss-import/issues/296

revelt commented 2 years ago

We've just released v0.2.0. Does anybody object if we close this issue?