search

eriklieben / aurelia-sortablejs

Aurelia plugin to use sortablejs https://github.com/RubaXa/Sortable
MIT License
8 stars 6 forks source link

Aurelia Bundle (jspm) do not include sortable.js #1

Open gp-slick-coder opened 7 years ago

gp-slick-coder commented 7 years ago

Hi, nice helper, only the bundle do not include the following file.

My configuration:

module.exports = {
  "bundles": {
    "dist/app-libs": {
      "includes": [
        "aurelia-framework",
         ...

        "sortablejs",
        "aurelia-sortablejs"
      ],
      "options": {
        "inject": true,
        "minify": true,
        "depCache": false,
        "rev": true
      }
    }
  }
};

The /jspm_packages/npm/aurelia-sortablejs@1.0.0/sortable.js is still loading separate.

image

Best regards, George

gp-slick-coder commented 7 years ago

https://github.com/oribella/aurelia-sortable/issues/30

gp-slick-coder commented 7 years ago

as a workaround we can include also the sortable.js file in the bundle like: "aurelia-sortablejs", "aurelia-sortablejs/sortable"

source: https://github.com/aurelia/bundler/issues/30

KoltesDigital commented 6 years ago

Sorry I didn't see this report. I just made a PR to fix it. I disagree with stoffeastrom's comment, the point of bundling is that everything is the bundle is loaded at once, so there is no point knowing whether sortable is loaded before or after index, they are loaded at the same time.