search

eriklindernoren / ML-From-Scratch

Machine Learning From Scratch. Bare bones NumPy implementations of machine learning models and algorithms with a focus on accessibility. Aims to cover everything from linear regression to deep learning.
MIT License
23.58k stars 4.55k forks source link

suggest renaming of acc_grad #32

Closed tomVeloso closed 6 years ago

tomVeloso commented 6 years ago

https://github.com/eriklindernoren/ML-From-Scratch/blob/c5256ff2d9e507a055094d7ce8064138706ab483/mlfromscratch/deep_learning/neural_network.py#L100 since you use .acc .loss in the function loss .. can be better change the name of the variable acc_grad

eriklindernoren commented 6 years ago

Hi,

Thanks for your feedback. Renaming acc_grad is a good suggestion. I changed the variable name in mlfromscratch/deep_learning/layers.py to accum_grad.

See c5256ff.

Cheers, Erik