search

erikng / Cacher

A python script for extracting macOS Caching Server data
Apache License 2.0
134 stars 40 forks source link

Wip #33

Closed calum-github closed 7 years ago

erikng commented 7 years ago

So I've tested all of this and I like it all, but I have a question:

Why don't we just grab the service logs for the calculated bandwidth? That has everything we need. I agree that we "don't need it", but it doesn't hurt to have.

I'm glad you changed the object prints > 0 - I should have done that.

calum-github commented 7 years ago

hmm i think mainly because i was just trying to sneak in compatibility for my existing 10.11.5 and server 5.1.5 machines as they don't have the service logs hahaha i have a lot of those out there because 10.12 and 5.2 has been very flakes for me with service stopping and service randomly restarting compared to 5.1.5

i think also as the debug log has everything we need including bandwidth we might as well just keep looking there

but up to you it's not that hard to change it :)

erikng commented 7 years ago

Fair enough. Merging.