search

eriknw / afar

Run code on a Dask cluster via a context manager or IPython magic
Other
30 stars 0 forks source link

Try to work with `%%time` and `%%timeit` IPython magic. #12

Closed eriknw closed 3 years ago

eriknw commented 3 years ago

Fixes #10. This is a pretty narrow fix that only applies to time and timeit.

@jrbourbeau care to give this a try, or should I just cut a release and hope for the best?

Testing notebooks is on my TODO list (and I want it to count towards line coverage too). I'll be sure to add %%time and %%timeit. I figured the line magic %time wasn't worth supporting.

jrbourbeau commented 3 years ago

I can confirm this fixes the issue I was seeing earlier today 👍

jrbourbeau commented 3 years ago

Thanks @eriknw!

eriknw commented 3 years ago

My pleasure! Lmao, afar is surprisingly fun to work on: "How I learned to stop worrying and love the [hacks]".

Thanks again for giving this a try and caring enough to raise issues :)