Completion of error handling

eriknyquist / librxvm

non-backtracking NFA-based regular expression library, for C and Python

Apache License 2.0

61 stars 1 forks source link

Completion of error handling #9

Open elfring opened 6 years ago

elfring commented 6 years ago

Would you like to add more error handling for return values from functions like the following?

fseek ⇒ bmh_partial
ftell ⇒ bmh

eriknyquist commented 6 years ago

Good catch, I'll fix that

eriknyquist commented 6 years ago

Fixed cae348f74edbd28879745d5e09ac2f9d0571d2ec

eriknyquist commented 6 years ago

Don't mind the red "x" from CI next to the new commits, the osx jobs on travis aren't running right now (high load I assume) so I've been cancelling them to run on the next commit. If you click into the details you see everything passed except the osx env.

elfring commented 6 years ago

How do you think about to improve static source code analysis also for your software?
Are you interested to apply aspect-oriented software development?

How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?