search

erikras / react-redux-universal-hot-example

A starter boilerplate for a universal webapp using express, react, redux, webpack, and react-transform
MIT License
12k stars 2.5k forks source link

All packages update + new airbnb lint + api auth + database #1200

Closed bertho-zero closed 7 years ago

guiguan commented 8 years ago

@bertho-zero so you have removed redux-async-connect, how did you retrieve data during SSR?

bertho-zero commented 8 years ago

@guiguan I have remplaced redux-async-connect by redux-connect, this is a fork and refactor of redux-async-connect, the dependencies have been updated to use react@^15, allowing Travis to finish its job properly.. and react is up to date

guiguan commented 8 years ago

Oh, I see. Nice. I thought that was normal redux connect :D

On 19 Jun 2016, at 23:07, Kévin Berthommier notifications@github.com wrote:

@guiguan I have remplaced redux-async-connect by redux-connect, this is a fork and refactor of redux-async-connect, the dependencies have been updated to use react@^15, allowing Travis to finish its job properly.. and react is up to date

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

JMacLulich commented 8 years ago

@bertho-zero thanks so much for this update! I'm going to use it as I want to use the latest dependencies such as React 15.

@bertho-zero Is there a way I can use your branch while waiting for @erikras to review this pull request?

bertho-zero commented 8 years ago

@JMacLulich Thanks, you can clone the project here, you can also add .diff or .patch extension to this url: https://github.com/erikras/react-redux-universal-hot-example/pull/1200.diff https://github.com/erikras/react-redux-universal-hot-example/pull/1200.patch

This pull request will not be accepted at this time because I've changed links that show dependencies badge, I would change it when the time comes if the request is likely to be accepted

bertho-zero commented 8 years ago

I switched babel-plugin-react-transform/react-transform-hmr to React Hot Loader, you can see Dan Abramov's tweet

React Hot Loader 3 React Hot Loader 3.0 beta demo

saan800 commented 8 years ago

Hi @bertho-zero I just tried to build your branch with the updates, and its got a dependency on python. What do i need to remove to make it not depend on that anymore?

bertho-zero commented 8 years ago

Hi @saan800 It's bcrypt who needs to compile with node-gyp and it also requires OpenSSL for compile. I use it for hash and compare password of user, this is useful only in the API.

korczis commented 8 years ago

Is this still up-to-date? Are there any plans to merge this in?

korczis commented 7 years ago

Is there any plan to merge this? @erikras ?