search

erikras / react-redux-universal-hot-example

A starter boilerplate for a universal webapp using express, react, redux, webpack, and react-transform
MIT License
11.99k stars 2.5k forks source link

Are you guys serializing css animation names on purpose? #584

Open mo-ib opened 8 years ago

mo-ib commented 8 years ago
screen shot 2015-11-19 at 6 33 23 pm screen shot 2015-11-19 at 6 34 22 pm
frankleng commented 8 years ago

@mibgs this is a technique used to create "local" scopes for CSS styles. basically every class specified this way becomes unique. if you want to reuse styles, see the composes rule https://github.com/webpack/css-loader

trueter commented 8 years ago

@mibgs You can avoid this behavior by wrapping the rules in :global, see https://github.com/erikras/react-redux-universal-hot-example/issues/556.

mo-ib commented 8 years ago

@trueter @frankleng The problem is not the css class name, it's the animation name (___Y_AjN). Why are these being serialized?

screen shot 2015-11-20 at 1 21 23 pm

screen shot 2015-11-20 at 1 21 35 pm

I've feel like I'm breaking the cool new rules by doing this, but it's the only way I could think to get out of my own way so I can keep working:

screen shot 2015-11-20 at 1 28 00 pm

trueter commented 8 years ago

Do these help?

frankleng commented 8 years ago

@mibgs see your point. I do think this is a bug in css-loader. looks like wrapping in :global is the right way to go, for now. or this https://github.com/webpack/css-loader/issues/166