Open AndrewRayCode opened 8 years ago
Sorry for wasting your time :(. Maybe it's problem with better-npm-run when watch-client
script not receive the env.PORT unless hard-coded, even when I put watch-client
script after start-dev
. Any suggestion ?
This commit is causing webpack-dev-server
running on the wrong port
==> 🚧 Webpack development server listening on port 30001
Heroku passes in a dynamic port to this project under
process.env.PORT
. When it's hard coded, the Heroku port (I believe) is ignored, and then Heroku tries to bind to the process under the port it expects, which nothing is running on, then eventually fails withDue to this commit:
https://github.com/erikras/react-redux-universal-hot-example/commit/3ec5ecb4a949c76d06da91d8a7688e8feefb3f48#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
Ping @trungtin and @quicksnap for merging https://github.com/erikras/react-redux-universal-hot-example/pull/966
This took me about 6 hours to debug :) Suggest rolling back change ASAP. I suspect many heroku deploys will fail with the latest version of this library using a hard coded port.