erikras / redux-form-material-ui

A set of wrapper components to facilitate using Material UI with Redux Form
http://erikras.github.io/redux-form-material-ui/
MIT License
831 stars 228 forks source link

Add typescript definitions for v5. #270

Open gilbsgilbs opened 6 years ago

gilbsgilbs commented 6 years ago

Fixes #223

Maybe not the most accurate definition, but works in my case. Unlike what I thought at first, it seems exhaustive (given that there's less components in v5 at the moment). Also, I'm pretty sure this doesn't follow best practices in term of dependency typing. Let me know if there's something I can do to improve.

codecov[bot] commented 6 years ago

Codecov Report

Merging #270 into 5.0 will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              5.0     #270   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           8        8           
  Lines          24       24           
=======================================
  Hits           16       16           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9328e93...d16c079. Read the comment docs.

diegolaciar commented 5 years ago

@erikras, would be very nice to have TS def in your project! :) @gilbsgilbs thanks for this PR

gilbsgilbs commented 5 years ago

@diegolaciar If this doesn't move much, we can make a PR to DefinitelyTyped instead. But this project doesn't seem maintained anymore unfortunately. PR and issues remains staled and v5 still isn't out although MUI 1.0 was released quite some time ago and prior versions of MUI are deprecated (I'm not even sure they're still supported).

alathon commented 5 years ago

@gilbsgilbs Did you ever make a PR to DefinitelyTyped ?

gilbsgilbs commented 5 years ago

@alathon Thanks for asking. No I didn't and I don't think I'll make it unless I have a substantial proof that this project is not abandonware. You can make a PR to DefinitelyTyped yourself if you really want :raised_hands: .

alathon commented 5 years ago

@gilbsgilbs Yeah, we've since moved to something else as well