Open gilbsgilbs opened 6 years ago
Merging #270 into 5.0 will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## 5.0 #270 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 8 8
Lines 24 24
=======================================
Hits 16 16
Misses 8 8
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9328e93...d16c079. Read the comment docs.
@erikras, would be very nice to have TS def in your project! :) @gilbsgilbs thanks for this PR
@diegolaciar If this doesn't move much, we can make a PR to DefinitelyTyped instead. But this project doesn't seem maintained anymore unfortunately. PR and issues remains staled and v5 still isn't out although MUI 1.0 was released quite some time ago and prior versions of MUI are deprecated (I'm not even sure they're still supported).
@gilbsgilbs Did you ever make a PR to DefinitelyTyped ?
@alathon Thanks for asking. No I didn't and I don't think I'll make it unless I have a substantial proof that this project is not abandonware. You can make a PR to DefinitelyTyped yourself if you really want :raised_hands: .
@gilbsgilbs Yeah, we've since moved to something else as well
Fixes #223
Maybe not the most accurate definition, but works in my case. Unlike what I thought at first, it seems exhaustive (given that there's less components in v5 at the moment). Also, I'm pretty sure this doesn't follow best practices in term of dependency typing. Let me know if there's something I can do to improve.