search

erikringsmuth / app-router

Router for Web Components
https://erikringsmuth.github.io/app-router/
MIT License
610 stars 83 forks source link

Router strips `#` from url params #121

Closed teckays closed 9 years ago

teckays commented 9 years ago

The router strips # character from route param. I think in case for pushstate it shouldn't, I have and app that lest users search for programming languages so the C# binds to C.

erikringsmuth commented 9 years ago

Do you have a full URL example?

teckays commented 9 years ago

I do but it has basic auth on it for now, will post back when we launch the project, hopefully tonight!

teckays commented 9 years ago

Ok, as promised, here is the link with a real life example: http://www.coders.pub/search/?location=germany&skill=c#

erikringsmuth commented 9 years ago

That's how browsers parse URLs. For example, you can type this in the console and see what it's doing.

new URL('http://www.coders.pub/search/?location=germany&skill=c#')

It might work to URL encode the # to %23.

teckays commented 9 years ago

Oh, I see, umm should have thought about that :|, sorry!