erikringsmuth / app-router

Router for Web Components
https://erikringsmuth.github.io/app-router/
MIT License
610 stars 83 forks source link

package.json should contain a version attribute #150

Closed kmturley closed 8 years ago

kmturley commented 8 years ago

According to npm instructions:

"The most important things in your package.json are the name and version fields. Those are actually required, and your package won't install without them." https://docs.npmjs.com/files/package.json

If you look at your package.json:

{
  "name": "app-router",
  "repository": {
    "type": "git",
    "url": "https://github.com/erikringsmuth/app-router.git"
  },
  "scripts": {
    "test": "node node_modules/gulp/bin/gulp.js ci"
  },
  "devDependencies": {}
}

It should contain a version e.g.

{
  "name": "app-router",
  "version": "2.6.1",
  "repository": {
    "type": "git",
    "url": "https://github.com/erikringsmuth/app-router.git"
  },
  "scripts": {
    "test": "node node_modules/gulp/bin/gulp.js ci"
  },
  "devDependencies": {}
}

I understand this will duplicate your bower.json, but I believe it should follow standards even if that means not being DRY