search

erikringsmuth / app-router

Router for Web Components
https://erikringsmuth.github.io/app-router/
MIT License
610 stars 83 forks source link

Make scrollToHash configurable #159

Closed web-padawan closed 7 years ago

web-padawan commented 7 years ago

Enable scrollToHash by default, but allow to disable it via scroll-to-hash="disabled" attribute. Fixes #158

web-padawan commented 7 years ago

@jmalonzo thanks. Would you tag these changes so we can use it?

jmalonzo commented 7 years ago

@web-padawan yep will do that once I've sorted out the build issues in node v7

web-padawan commented 7 years ago

@jmalonzo Some deps outdated? Looks like v7 migration might be a really breaking change in some cases (not sure if it makes sense for app-router, but still).

jmalonzo commented 7 years ago

@web-padawan Sorry took a while.. It's just the build side of it but tests seem to be OK. Anyway, 2.7.2 should be out.

web-padawan commented 7 years ago

Thanks!