search

erikringsmuth / app-router

Router for Web Components
https://erikringsmuth.github.io/app-router/
MIT License
610 stars 83 forks source link

Fix #163: binding with custom names #164

Closed oesleik closed 7 years ago

web-padawan commented 7 years ago

Setting attribute is not the same as setting the property. E. g. in Polymer 1.x there is attribute deserialization. I think the element itself should catch property setting and only reflect it to attribute if necessary (in Polymer 1.x, this is configured via reflectToAttribute: true). If you really need setting attribute, you should make this stuff opt-in and disabled by default for compatibility.

oesleik commented 7 years ago

I agree with your considerations. Maybe the right thing to do is explain it properly on the README then.

web-padawan commented 7 years ago

Good catch. README is confusing in this case.