erikringsmuth / app-router

Router for Web Components
https://erikringsmuth.github.io/app-router/
MIT License
611 stars 83 forks source link

Navigation through core-toolbar on mobile devices not working (hash-routing) #33

Closed SH4DY closed 9 years ago

SH4DY commented 9 years ago

Hello,

clicking on core-items in core-toolbar in my app does not trigger routing on mobile devices (URL does not get changed). Routing itself works (typing and surfing directly to /#/xyz). I did not change any behaviour, just put some content into the sample app. Navigation in the sample https://erikringsmuth.github.io/app-router/#/ works, too!

Not sure if this is some kind of bug?

Tested on Chrome for G3, Nexus 9 and Safari on iPhone 6 and 4S.

You can test it on resume.shadysblog.com

stefanasseg commented 9 years ago

I have seen the exact same problem on Chrome on my HTC One Max. However, I'm experiencing that sometimes it does trigger routing but most times it does not.

SH4DY commented 9 years ago

So I checked and this is not an issue of the core-toolbar, none of the links are working on the page.

My workaround for now is setting on-tap on the core items and fire document.querySelector('app-router').go('/xyz')

erikringsmuth commented 9 years ago

Polymer recently fixed core-item so that you could put the link inside of it like this.

<core-item icon="home" label="Home">
  <a href="#/home"></a>
</core-item>

Previously I had to put the core-item in the a tag like this.

<a href="#/home">
  <core-item icon="home" label="Home"></core-item>
</a>

I wonder if it's something related to this. The only thing I can think of that would break it is if it never fired a popstate or hashchange event. Clicking a link with a hash should always fire one of these two.

erikringsmuth commented 9 years ago

Do either of you know if this is still an issue? If you have example code I could run that'd be great too.

erikringsmuth commented 9 years ago

Closing for now since I can't reproduce it. If you get an example of the bug open it back up. Sample code would be really helpful too.