search

erikringsmuth / app-router

Router for Web Components
https://erikringsmuth.github.io/app-router/
MIT License
611 stars 83 forks source link

paths are confusing in the gh-pages demo #9

Closed ghost closed 10 years ago

ghost commented 10 years ago

it looks for the polymer.html down in app router bower folder.

http://127.0.0.1:49399/app-router/bower_components/polymer/polymer.html

ghost commented 10 years ago

cant find where to change this in the code.

erikringsmuth commented 10 years ago

This was an issue I ran into because github pages puts everything behind the path /app-router/. I was lazy and made all of the links hard coded to start with /app-router/ to get it working. I just did a quick run through and switched everything to relative paths. This gets it working both locally an on gh-pages (with or without /app-router/).

Hope that helps!

https://github.com/erikringsmuth/app-router/commit/9d4b08d16349c78023bb83928be485b30c1d2276

ghost commented 10 years ago

Yep i found it. Thanks for fast response.

Git Hub is painful that way.

I am using Huge to generate pages server side, and so can template all of this into it. This gets around all the issues like this. WIth a simple setting i can generate the whole site with different base paths Or different menu structure. It insanely fast and goes live watching. But takes a bit of getting used to. have a look :) You will probaby like it. http://hugo.spf13.com/

erikringsmuth commented 10 years ago

And written in Go, nice! I'll have to check it out tonight.

ghost commented 10 years ago

I am looking to extend from what you have done. DO you have a roadmap ?

erikringsmuth commented 10 years ago

I don't have too much more planned. @ChrisMcKenzie and I are looking at what it would take to add life-cycle events https://github.com/erikringsmuth/app-router/issues/7.

I'd also like to split apart the source so I can get the unit tests working from the command line. I have to run them from the browser because none of the Node or PhantomJS test runners support custom elements.

I'm definitely open to ideas!

erikringsmuth commented 10 years ago

Clarified here http://erikringsmuth.github.io/app-router/#/notes

I also added a note to the gh-pages readme about the links all being relative paths to support the /app-router/ gh-pages prefix.