search

erikrose / parsimonious

The fastest pure-Python PEG parser I can muster
MIT License
1.82k stars 128 forks source link

Fix print statement in benchmarks #122

Closed cbgbt closed 7 years ago

cbgbt commented 7 years ago

After this change I was capable of running this benchmark with both Python 2 and Python 3.

lucaswiman commented 7 years ago

Should this be run as part of the test suite?

cbgbt commented 7 years ago

They seem to not already be part of the test suite per this comment.

It could be worth running this during testing to ensure that it still works. If there's a way to get nose to conditionally run tests, we could disable this by default but run it in Travis.

erikrose commented 7 years ago

Yep, nose has attributes we can tag tests with. It can then run only certain tests, depending on boolean combinations of attributes. I'm not against this. We'd have to rename this file so nose ventures into it by default.

cbgbt commented 7 years ago

Looks like someone else fixed this in #128, so I'll go ahead and close this. Sorry for my latency :).