Closed swayson closed 2 years ago
Good catch @evanh I have updated it.
Great teamwork, you two! Thank you! Regretfully, the landing of #135 has caused a few conflicts. :-/
Fixed the conflict 👍
Hello. Any news on this?
Ooof, blast of the past. Haven't picked this up in awhile sorry and probably won't have time in coming weeks. @erikrose is this still the only change you wanted to make for this PR?
Thank you, both, for the contribution! This is necessary for getting parsimonious to work on python 3.10, which breaks nose. You've saved me a bunch of time. I'll add the necessary patch to revert the whitespace changes to maintain consistency.
This passes for me locally, but no longer passes on CI. Somewhere in late 2019 both pytest
and pytest-runner
dropped support for 2.7. CI is grabbing pytest-runner-6.0.0
which does not support 2.7 and does not install.
I suspect we could pin earlier versions of pytest and pytest runner, though I'm in favor dropping support for 2.x instead, going forward.
@erikrose what do you think about dropping support for 2.x?
Drop it! Thanks for sprucing things up, Lonnen!
On Mar 22, 2022, at 03:40, Lonnen @.***> wrote:
Thank you, both, for the contribution! This is necessary for getting parsimonious to work on python 3.10, which breaks nose. You've saved me a bunch of time. I'll add the necessary patch to revert the whitespace changes to maintain consistency.
This passes for me locally, but no longer passes on CI. Somewhere in late 2019 both pytest and pytest-runner dropped support for 2.7. CI is grabbing pytest-runner-6.0.0 which does not support 2.7 and does not install.
I suspect we could pin earlier versions of pytest and pytest runner, though I'm in favor dropping support for 2.x going forward.
@erikrose what do you think about dropping support for 2.x?
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.
I've manually merged the two substantive commits (thanks again @evanh, @swayson!) and instead of bringing in the merge commit with its unwanted whitespace changes I ported the substantive changes from the merge commit by hand. The order of single and double quotes swapped in string representations so asserts with mixed '
and "
needed to have one side flipped.
Hi @erikrose
Here is the PR for the provided patch in https://github.com/erikrose/parsimonious/issues/160