search

erikrose / peep

A "pip install" that is cryptographically guaranteed repeatable
MIT License
221 stars 28 forks source link

Add support for pip 8.x #113

Closed edmorley closed 8 years ago

edmorley commented 8 years ago

Pip 8 has deprecated the --allow-external, --allow-unverified and --allow-all-external options, since they they now a no-op after changes to PyPI, even with older versions of pip: https://github.com/pypa/pip/pull/3070#issuecomment-137464224

Removing handling for these in peep does not affect older versions of pip, but avoids an exception for each removed option with pip v8: TypeError: __init__() got an unexpected keyword argument 'allow_unverified'

Whilst pip v8 adds native hashing support, it's helpful for peep to support v8 so that users can separate the "update pip" and "switch from peep to pip hashes" steps.

Fixes #112.

CC @erikrose

erikrose commented 8 years ago

You're a really good person, @edmorley. :-)

edmorley commented 8 years ago

I have a fix for the test failures locally (unpinned virtualenv in the travis tox install ironically :-)).

erikrose commented 8 years ago

You sure figured that out fast!

edmorley commented 8 years ago

Eugh there were failures with virtualenv==14.0.0 after all; I've just gone full circle again (after a few bouts of indecision) and pinned it to the previously working version. Serves me right for being lazy and using Travis to test instead of doing so locally (I don't have most of the interpreters installed) :-)

erikrose commented 8 years ago

wfm. FWIW, I also don't care if we continue to support Python 3.2; pip just dropped support, and I don't imagine it has much userbase.