search

eriktim / elm-protocol-buffers

An Elm implementation of the Protocol Buffers specification
https://package.elm-lang.org/packages/eriktim/elm-protocol-buffers/latest/
BSD 3-Clause "New" or "Revised" License
32 stars 3 forks source link

Fix performance issue #5

Closed MartinSStewart closed 2 years ago

MartinSStewart commented 2 years ago

Decoding large packed lists of values is very slow due to each item being placed on the end of the list instead of at the beginning (in my use case, this issue made decoding take 15 seconds instead of 100ms). This PR fixes that issue.

eriktim commented 2 years ago

Thanks for this @MartinSStewart. Please allow me some time to fix the CI pipeline first.

eriktim commented 2 years ago

@MartinSStewart can you please rebase your branch on master?

MartinSStewart commented 2 years ago

Done!